Show CA "Needs attention" #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbrownus
previously approved these changes
Dec 5, 2024
|
I'm going to back out some of this then, and work on showing a warning prompt that can be accepted to save an invalid config. |
This reverts commit 3cea52a.
johnmaguire
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #191This makes Android behave more like iOS, wherein it is not possible to save an invalid site. As a bonus here, we'll display a more useful error message as well, referencing why the form cannot be saved.This fixes a bug to correctly mark CA as "Needs attention" if it is empty (and the site is not managed) ref: #202
To test:- In Android, create a new site, give it a name, and save. You should get an error message.- Then fill out the certificate and CA, and again save. It should still properly save the site.Open question:
Answer: we want to avoid requiring a valid config. Much of this PR has been removed for now, only leaving the CA needs attention fix.