-
-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
T30 Omni new features (full support) #555
Comments
Do you have the technical skills to contribute the code directly via a pull request? |
Unfortunately I'm not skilled enough. |
I managed to set up a test environment on my linux vm. Then I tried to add True Detect Sensitivity feature and ran into issues, because it's a "select" entity, not a switch, so it requires more effort.
enable defines on/off Then I tried to add a TrueDetectSensitivity capability to define only the level of sensitivity, by just copy/editing WorkMode capability I discovered that the enable argument is required (0 or 1 value it works the same), while the level argument is optional so I had to revert all the changes because I lost myself trying to send 2 arguments If you have suggestions or examples it could help me a lot |
Sorry for the delay, but I had a rough month due to an accident. I'm fine Please feel free to open a PR on the client here and after that one is merged and if it's required I can assist you on the PR for home assistant core. It's possible that core will show a select entity instead of a switch if there are more options available (I can implement it for you after you have open the PR for the client part here) |
Hi all, |
Hi there,
I hope I've been clear enough to be helpful |
Looks like you implemented and tested this change. If it is working for you, could you please create a Pull Request? |
- Initial clone of most compatible, requires extra features not supported yet in DeebotUniverse#555
- Initial clone of most compatible, requires extra features not supported yet in #555
Found this while looking to add X5 Pro Omni support, one thing that is worth noting is that Do Not Disturb is a one-to-many not one-to-one. You can have multiple Do Not Disturb schedules it's not as simple as just a single map on any Getter. |
Contributes DeebotUniverse#555 - Add support for Mop Auto-Wash Frequency `setWashInterval`
Also just an FYI to divide and conquer I have started working on the Mop Auto-Wash Frequency in a fork branch 😊 |
@edenhaus can you just confirm how you have been handling new capabilities with the many-to-one symlinking. Further up in this thread there is the setChildLock capability already existing but not attached to In the past have you been updating the source of the symlink or branching off into a new file for these where a new capability needs to be added that may not exist on ALL symlinked devices? Both T30 (
|
@pepperonzo can you confirm with certainty that the API endpoint for Wash Interval by Time is I tried to build based on this but from it not working in testing went back to dump from my X5 Pro Omni and discovered that on my device both the interval and time/room selector is a part of the
|
When adding a new feature, we will add it to the capabilities of the models we know. For example, if the T20 ( Did I explain it understandable? |
That makes sense thanks! I just didn't know if it was played on the cautious side because some features may not be listed on official spec sheets but available in the app. |
Here is the debug log of my T30 when I try to change mop wash interval
I always focused on iot/p2p messages and ignored iot/atr ones because from what I read they're not compatible with this library. |
@XxInvictus I just tested get commands also
They BOTH seem to work as the set commands only "mode", "interval" and "roomwise" are in common with your output |
Ref DeebotUniverse#555 - Add support for Mop Auto-Wash Frequency - Add Capability to T20/T30 Omni/X5 Pro Omni via `p1jij8.py`
Ref DeebotUniverse#555 - Add support for Mop Auto-Wash Frequency - Add Capability to T20/T30 Omni/X5 Pro Omni via `p1jij8.py` Fix missing list seperator Make pre-commit happy Fix error in SetAutoMopWashFrequency test case Small fix to resolve Mop Auto Wash and checkers not agreeing with int
Ref DeebotUniverse#555 - Add support for Mop Auto-Wash Frequency - Add Capability to T20/T30 Omni/X5 Pro Omni via `p1jij8.py` Fix missing list seperator Make pre-commit happy Fix error in SetAutoMopWashFrequency test case Small fix to resolve Mop Auto Wash and checkers not agreeing with int Ruff lint/format
Ref DeebotUniverse#555 - Add support for Mop Auto-Wash Frequency - Add Capability to T20/T30 Omni/X5 Pro Omni via `p1jij8.py` Fix missing list seperator Make pre-commit happy Fix error in SetAutoMopWashFrequency test case Small fix to resolve Mop Auto Wash and checkers not agreeing with int Ruff lint/format Ruff Linting/Fixes
#677 should be good to go for supporting the Auto Mop-Wash time, just need to create the PR against the homeassitant/core repo to add the support for the entities on that end. |
Ref DeebotUniverse#555 - Add support for Mop Auto-Wash Frequency - Add Capability to T20/T30 Omni/X5 Pro Omni via `p1jij8.py` Fix missing list seperator Make pre-commit happy Fix error in SetAutoMopWashFrequency test case Small fix to resolve Mop Auto Wash and checkers not agreeing with int Ruff lint/format Ruff Linting/Fixes
Checks
The problem
Home Assistant doesn't support all new features of Deebot T30 Omni (many of them in common with T20)
I've mapped them all, but I think I lack the knowledge to implement them by myself.
All I can do is a copy->paste->edit work and, for what I've seen, it's not enough.
Hope this can help
I've put them in excel for better reading
T30 features.xlsx
On which deebot device (vacuum) you have the issue?
Deebot T30 Omni
Which version of the deebot-client are you using?
8.3.0
Country
it
Continent
eu
Anything in the logs that might be useful for us?
No response
Additional information
No response
The text was updated successfully, but these errors were encountered: