-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for active_model_serializers (>= 0.9.0) #58
Comments
AMS 0.9 support shouldn't be to hard to add, but AMS 1.0 uses the JSON API serialization format and would likely require a backwards incompatible rewrite of most of the code. |
I believe AMS 0.9 support would be great, as grape-active_model_serializers has many stable versions compatible with it. |
@rsespinosa Would you like to work on a PR to add 0.9 compatibility? I've had a look at this about two weeks ago but ran out of time, so I could push my WIP branch. I've implemented most of the changes required in interfacing with the new version without breaking backwards compatibility, but there's likely still a some hours work required to get the tests to pass. |
Hi @felixbuenemann , I'm sorry for the late reply. I've been pretty complicated myself. |
I pushed my sprint as a WIP commit to this branch: https://github.com/felixbuenemann/postgres_ext-serializers/tree/wip/ams-0.9-support |
@felixbuenemann @rsespinosa I was wondering if you guys are still working on AMS 0.9x support? |
@oyeanuj I'm not actively working on it, feel free to work on the WIP branch. |
Is there any chance you can add active_model_serializers (>= 0.9.0) support any time soon?
Being able to use "grape-active_model_serializers" combined with "postgres_ext-serializers" would be a major win for any rails api.
Thanks and regards,
The text was updated successfully, but these errors were encountered: