Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect hue gradient used #39

Open
Zyets opened this issue May 31, 2017 · 1 comment
Open

Incorrect hue gradient used #39

Zyets opened this issue May 31, 2017 · 1 comment

Comments

@Zyets
Copy link

Zyets commented May 31, 2017

I don't know how you get that values... for me it looks like you randomly picked them from some sample...
That are correct:
#ff0000 0%,
#ffff00 16.7%,
#00ff00 33.3%,
#00ffff 50%,
#0000ff 66.7%,
#ff00ff 83.3%,
#ff0000 100%

here is some math logic used, dude
hue wiki

ps i like your rgb2hex method though)) its awesome!
Best regards)

@simonh1000
Copy link

I had a go with @Zyets suggestion and it seem to work well except near the yellow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants