Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] [dinky-admin] Uniformly use '/' as the file separator. #3914

Merged
merged 4 commits into from
Nov 15, 2024

Conversation

Jam804
Copy link
Contributor

@Jam804 Jam804 commented Nov 13, 2024

Purpose of the pull request

[Fix] [dinky-admin] Uniformly use '/' as the file separator.

When synchronizing the resource directory structure in local mode, different file separators may be generated due to differences in operating systems.

Brief change log

This change added tests and can be verified as follows:

Test results ensure that the full file name can be generated using the '/' separator on both Windows and Linux systems.

@Jam804
Copy link
Contributor Author

Jam804 commented Nov 13, 2024

image

This is the result of running on Windows before the modification.

@Jam804
Copy link
Contributor Author

Jam804 commented Nov 15, 2024

@aiwenmo PTAL, Thanks

Copy link
Contributor

@gaoyan1998 gaoyan1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaoyan1998 gaoyan1998 merged commit cff1970 into DataLinkDC:dev Nov 15, 2024
19 checks passed
@Zzm0809 Zzm0809 added the Bug Something isn't working label Nov 18, 2024
@Zzm0809 Zzm0809 added this to the 1.2.0 milestone Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants