Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[datadog_monitor] Change enable_samples to optional #2680

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lexicalunit
Copy link

@lexicalunit lexicalunit commented Nov 15, 2024

Resolves #2679

This value should be optional, defaulted to false. It should not be marked as computed.

@lexicalunit lexicalunit requested review from a team as code owners November 15, 2024 17:59
@lexicalunit
Copy link
Author

How can I get a review here?

@nkzou nkzou requested a review from a team as a code owner December 17, 2024 15:55
@nkzou nkzou changed the title Change enable_samples to optional [datadog_monitor] Change enable_samples to optional Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enable_samples can not be set
2 participants