Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Language example for 'js' is not recognized in UI v2.2 #27

Open
jmitash opened this issue Nov 3, 2023 · 1 comment · May be fixed by #30
Open

Language example for 'js' is not recognized in UI v2.2 #27

jmitash opened this issue Nov 3, 2023 · 1 comment · May be fixed by #30

Comments

@jmitash
Copy link

jmitash commented Nov 3, 2023

The examples for languages field lists js as a recognizable language:

schema/service-catalog/v2.2/schema.json

Line 53 in ba16abf

"examples": [["dotnet", "go", "java", "js", "php", "python", "ruby", "c++"]],

However, now that v2.2 is supported in the UI, it seems like javascript is recognized but js is not:
image

Perhaps the example should be updated to javascript?
@juancarlosjr97
Copy link

I have noticed this too adding the language manually. I will raise a PR to fix the schema as js as the schema shows is not recognised.

juancarlosjr97 added a commit to juancarlosjr97/schema that referenced this issue Nov 22, 2023
@juancarlosjr97
Update schema of v2.2 to fix js to javascript
209e536 
Updating schema of v2.2 to add to the list of array a correct id for JavaScript as `javascript`

Fixes DataDog#27
@juancarlosjr97 juancarlosjr97 linked a pull request Nov 22, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update schema of v2.2 to fix js to javascript juancarlosjr97/schema
2 participants
@jmitash @juancarlosjr97