nvml: add support for datadog agent >= 7.56 #2535
Conversation
maxgio92
changed the title
maxgio92
changed the title
|
Hi @Kyle-Neale, may I ask you a feedback around this? |
maxgio92
changed the title
|
Hello @cep21! I think you are the maintainer for this particular integration. Would you mind having a look and see if this is something you would like to accept? Thanks! |
The current generated protobuf code is no longer compatible with the version of runtime protobuf implementation bundled with the Datadog Agent. This api protobuf code is regenerated using Python protobuf 5.27.2. It should be compatible with Agent >= 7.56.0. Signed-off-by: Massimiliano Giovagnoli <[email protected]>
maxgio92
force-pushed
the
nvml-protobuf-update
branch
from
b721d01 to
d07247f
Compare
|
Thank you @cep21, I've noticed that there was a conflict, so I've solved it now. |
maxgio92
force-pushed
the
nvml-protobuf-update
branch
from
8f6c4fa to
c042150
Compare
Signed-off-by: Massimiliano Giovagnoli <[email protected]>
maxgio92
force-pushed
the
nvml-protobuf-update
branch
from
c042150 to
b8f31b3
Compare
Bump pynvml patch version to 11.5.3 and grpcio minor to 1.68.0. Signed-off-by: Massimiliano Giovagnoli <[email protected]>
|
I fixed the integration tests by bumping Now the CI is complaining for non optimal code coverage 🫠 In the meantime I'm working to reach 75% target. |
Signed-off-by: Massimiliano Giovagnoli <[email protected]>
This reverts commit 96c3891.
maxgio92
changed the title
maxgio92
changed the title
Signed-off-by: Massimiliano Giovagnoli <[email protected]>
maxgio92
force-pushed
the
nvml-protobuf-update
branch
from
6d9e6c8 to
2d46e2c
Compare
|
@cep21 may I ask you to re-validate and possibly approve this PR? :) |
|
Hi @CEP2 , I noticed from the |
|
I think there are three approving reviews, which is more than 1. Am I missing something? 🤔 |
|
@maxgio92 one of the reviews need to come from someone with writing access to the repo |
What does this PR do?
This PR introduces the NVML check protobuf code regenerated with Python implementation of protobuf version 5.27.2. It should be compatible with Agent >= 7.56.0.
$ docker run --rm -it --entrypoint pip datadog/agent:7.56.0 freeze | grep protobuf protobuf @ https://agent-int-packages.datadoghq.com/external/protobuf/protobuf-5.27.2-cp38-abi3-manylinux2014_x86_64.whl#sha256=b848dbe1d57ed7c191dfc4ea64b8b004a3f9ece4bf4d0d80a367b76df20bf36eBreaking changes: it is going to be incompatible with Datadog Agent < 7.56.0, because the runtime Python protobuf version should be greater or equal to the one used to regenerate the code.
Motivation
The current generated protobuf code for the NVML check of the integration with NVML is no longer compatible with the version of runtime protobuf implementation bundled with the Datadog Agent (since version 7.51).
See #2382.
Review checklist
no-changeloglabel attachedAdditional Notes
Fixes #2382