From 61933afa2a292dc5ff645279b144b9c9b82b0b03 Mon Sep 17 00:00:00 2001 From: Austin Lai <76412946+alai97@users.noreply.github.com> Date: Wed, 29 Jun 2022 16:52:37 -0700 Subject: [PATCH 1/6] Spacing Nit --- docs/rum_getting_started.md | 39 +++++++++++++++++++------------------ 1 file changed, 20 insertions(+), 19 deletions(-) diff --git a/docs/rum_getting_started.md b/docs/rum_getting_started.md index 99e6e7f4f4..54f881b6fa 100644 --- a/docs/rum_getting_started.md +++ b/docs/rum_getting_started.md @@ -285,7 +285,9 @@ public class SampleApplication extends Application { {{< /tabs >}} {{< /site-region >}} -The credentials for initialization require your application's variant name and uses the value of `BuildConfig.FLAVOR` or an empty string if you don't have variants. This enables the correct ProGuard `mapping.txt` file to automatically upload at build time so you can view de-obfuscated RUM error stack traces. For more information, see the [guide to uploading Android source mapping files][8]. +The initialization credentials require your application's variant name and uses the value of `BuildConfig.FLAVOR`. If you do not have variants, the credentials uses an empty string. + +This enables the appropriate ProGuard `mapping.txt` file to automatically upload at build time so you can view deobfuscated RUM error stack traces. For more information, see the [Track Android Errors][8]. ### Initialize the RUM Monitor and Interceptor @@ -300,8 +302,8 @@ GlobalRum.registerIfAbsent(monitor) {{% /tab %}} {{% tab "Java" %}} ```java - final RumMonitor monitor = new RumMonitor.Builder().build(); - GlobalRum.registerIfAbsent(monitor); +final RumMonitor monitor = new RumMonitor.Builder().build(); +GlobalRum.registerIfAbsent(monitor); ``` {{% /tab %}} {{< /tabs >}} @@ -311,16 +313,16 @@ To track your OkHttp requests as resources, add the provided [Interceptor][9]: {{< tabs >}} {{% tab "Kotlin" %}} ```kotlin - val okHttpClient = OkHttpClient.Builder() - .addInterceptor(DatadogInterceptor()) - .build() +val okHttpClient = OkHttpClient.Builder() + .addInterceptor(DatadogInterceptor()) + .build() ``` {{% /tab %}} {{% tab "Java" %}} ```java - final OkHttpClient okHttpClient = new OkHttpClient.Builder() - .addInterceptor(new DatadogInterceptor()) - .build(); +final OkHttpClient okHttpClient = new OkHttpClient.Builder() + .addInterceptor(new DatadogInterceptor()) + .build(); ``` {{% /tab %}} {{< /tabs >}} @@ -337,17 +339,16 @@ You can track events such as crashes and network requests when your application Add the following snippet during initialization in your Datadog configuration: - {{< tabs >}} +{{< tabs >}} {{% tab "Kotlin" %}} - ```kotlin - .trackBackgroundRumEvents(true) - ``` +```kotlin +.trackBackgroundRumEvents(true) +``` {{% /tab %}} - {{% tab "Java" %}} - ```java - .trackBackgroundRumEvents(true) - - ``` +{{% tab "Java" %}} +```java +.trackBackgroundRumEvents(true) +``` {{% /tab %}} {{< /tabs >}}

Tracking background events may lead to additional sessions, which can impact billing. For questions, contact Datadog support.

@@ -371,4 +372,4 @@ Add the following snippet during initialization in your Datadog configuration: [11]: https://docs.datadoghq.com/real_user_monitoring/android/advanced_configuration/#automatically-track-network-requests [12]: https://github.com/DataDog/dd-sdk-android-gradle-plugin [13]: https://docs.datadoghq.com/real_user_monitoring/android/web_view_tracking/ -[14]: https://docs.datadoghq.com/getting_started/tagging/using_tags/#rum--session-replay \ No newline at end of file +[14]: https://docs.datadoghq.com/getting_started/tagging/using_tags/#rum--session-replay From 3ad6bab09377542a0224e7385d11da9b3c00deaf Mon Sep 17 00:00:00 2001 From: Austin Lai <76412946+alai97@users.noreply.github.com> Date: Thu, 30 Jun 2022 13:17:44 -0700 Subject: [PATCH 2/6] Carry Over Nit --- docs/rum_getting_started.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/rum_getting_started.md b/docs/rum_getting_started.md index 54f881b6fa..6108edbd92 100644 --- a/docs/rum_getting_started.md +++ b/docs/rum_getting_started.md @@ -51,7 +51,7 @@ For more information about setting up a client token, see the [Client Token docu ### Initialize the library with application context -In the initialization snippet, set an environment name, service name, and version number. In the examples below, `APP_VARIANT_NAME` specifies the name of the service that generates data. For more information, see [Using Tags][14]. +In the initialization snippet, set an environment name, service name, and version number. In the examples below, `APP_VARIANT_NAME` specifies the variant of the application that generates data. For more information, see [Using Tags][14]. See [`ViewTrackingStrategy`][5] to enable automatic tracking of all your views (activities, fragments, and more), [`trackingConsent`][6] to add GDPR compliance for your EU users, and [other configuration options][7] to initialize the library. From 2030bc5f231e147d3c7e3f097fc07184a555329b Mon Sep 17 00:00:00 2001 From: Austin Lai <76412946+alai97@users.noreply.github.com> Date: Thu, 30 Jun 2022 14:45:10 -0700 Subject: [PATCH 3/6] SME Review --- docs/rum_getting_started.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/rum_getting_started.md b/docs/rum_getting_started.md index 6108edbd92..0f6f3e42f4 100644 --- a/docs/rum_getting_started.md +++ b/docs/rum_getting_started.md @@ -285,9 +285,9 @@ public class SampleApplication extends Application { {{< /tabs >}} {{< /site-region >}} -The initialization credentials require your application's variant name and uses the value of `BuildConfig.FLAVOR`. If you do not have variants, the credentials uses an empty string. +The initialization credentials require your application's variant name and uses the value of `BuildConfig.FLAVOR`. With the variant, RUM can match the errors reported from your application with the mapping files uploaded by the Gradle plugin. If you do not have variants, the credentials uses an empty string. -This enables the appropriate ProGuard `mapping.txt` file to automatically upload at build time so you can view deobfuscated RUM error stack traces. For more information, see the [Track Android Errors][8]. +The Gradle plugin automatically uploads the appropriate ProGuard `mapping.txt` file at build time so you can view deobfuscated RUM error stack traces. For more information, see the [Track Android Errors][8]. ### Initialize the RUM Monitor and Interceptor From 158e017bdada4a7aa033aec0c7bce321ad2475f5 Mon Sep 17 00:00:00 2001 From: Heston Hoffman Date: Tue, 5 Jul 2022 08:21:40 -0700 Subject: [PATCH 4/6] Update docs/rum_getting_started.md --- docs/rum_getting_started.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/rum_getting_started.md b/docs/rum_getting_started.md index 0f6f3e42f4..1ccd78bb28 100644 --- a/docs/rum_getting_started.md +++ b/docs/rum_getting_started.md @@ -285,7 +285,7 @@ public class SampleApplication extends Application { {{< /tabs >}} {{< /site-region >}} -The initialization credentials require your application's variant name and uses the value of `BuildConfig.FLAVOR`. With the variant, RUM can match the errors reported from your application with the mapping files uploaded by the Gradle plugin. If you do not have variants, the credentials uses an empty string. +The initialization credentials require your application's variant name and uses the value of `BuildConfig.FLAVOR`. With the variant, RUM can match the errors reported from your application with the mapping files uploaded by the Gradle plugin. If you do not have variants, the credentials use an empty string. The Gradle plugin automatically uploads the appropriate ProGuard `mapping.txt` file at build time so you can view deobfuscated RUM error stack traces. For more information, see the [Track Android Errors][8]. From 20146adfbd9fa654a0a2366b4236f804c9289312 Mon Sep 17 00:00:00 2001 From: Nikita Ogorodnikov Date: Thu, 28 Jul 2022 15:17:11 +0200 Subject: [PATCH 5/6] Update statement about default view tracking strategy in the docs --- docs/configure_rum_android_sdk.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/configure_rum_android_sdk.md b/docs/configure_rum_android_sdk.md index 2671ca71d1..bd4781e5b3 100644 --- a/docs/configure_rum_android_sdk.md +++ b/docs/configure_rum_android_sdk.md @@ -244,7 +244,7 @@ For instance, to set each fragment as a distinct view, use the following configu **Tip**: For `ActivityViewTrackingStrategy`, `FragmentViewTrackingStrategy`, or `MixedViewTrackingStrategy` you can filter which `Fragment` or `Activity` is tracked as a RUM View by providing a `ComponentPredicate` implementation in the constructor. -**Note**: By default, the library does not track any views. If you decide not to provide a view tracking strategy, you must manually send the views by calling the `startView` and `stopView` methods yourself. +**Note**: By default, the library is using `ActivityViewTrackingStrategy`. If you decide not to provide a view tracking strategy, you must manually send the views by calling the `startView` and `stopView` methods yourself. ### Automatically track network requests From 46f7b1fdd3ac6e5c5bc1fec6bfbe07702af136b4 Mon Sep 17 00:00:00 2001 From: Austin Lai <76412946+alai97@users.noreply.github.com> Date: Mon, 8 Aug 2022 10:45:51 -0700 Subject: [PATCH 6/6] Removes View Loading Time Metric --- docs/mobile_data_collected.md | 1 - 1 file changed, 1 deletion(-) diff --git a/docs/mobile_data_collected.md b/docs/mobile_data_collected.md index 1eb2544436..a5fb718746 100644 --- a/docs/mobile_data_collected.md +++ b/docs/mobile_data_collected.md @@ -124,7 +124,6 @@ RUM action, error, resource, and long task events contain information about the | Metric | Type | Description | |----------------------------------------|-------------|----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| | `view.time_spent` | number (ns) | Time spent on this view. | -| `view.loading_time` | number (ns) | Loading time for this view. | | `view.long_task.count` | number | Count of all long tasks collected for this view. | | `view.error.count` | number | Count of all errors collected for this view. | | `view.resource.count` | number | Count of all resources collected for this view. |