ID-822 Use new Sam endpoint for Signed URLs #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #77 +/- ##
============================================
- Coverage 84.17% 84.13% -0.04%
Complexity 228 228
============================================
Files 36 36
Lines 809 807 -2
Branches 75 75
============================================
- Hits 681 679 -2
Misses 96 96
Partials 32 32
☔ View full report in Codecov by Sentry. |
|
Integration test is expected to fail until broadinstitute/sam#1193 ships |
nmalfroy
approved these changes
Sep 28, 2023
| post: | ||
| summary: gets a signed url for a blob using the pet service account for the user in the provided project | ||
| summary: gets a signed url for a blob using the arbitrary pet service account for the user and an optional requester pays google project |
There was a problem hiding this comment.
Again, I'd love to understand why it needs to be arbitrary. The project should get passed in by the client. I worry this will cause permissions issues
There was a problem hiding this comment.
Removed all references to Pet Service Accounts
Shakespeared
approved these changes
Sep 28, 2023
nmalfroy
reviewed
Sep 29, 2023
| @@ -95,7 +95,7 @@ public static void setupDrsResolutionServiceMocks( | |||
| any(BearerToken.class), | |||
| eq(true), | |||
| nullable(String.class), | |||
| nullable(String.class)); | |||
| eq(googleProject)); | |||
There was a problem hiding this comment.
I'm like 90% sure this is causing the tests to fail
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new Signed URL Endpoint is being created in Sam to correctly handle signed urls for requester-pays buckets. DRSHub should use it.
broadinstitute/sam#1193