diff --git a/.github/workflows/unit_test.yml b/.github/workflows/unit_test.yml index a479154ca8f..c3e7fbd9054 100644 --- a/.github/workflows/unit_test.yml +++ b/.github/workflows/unit_test.yml @@ -21,7 +21,7 @@ jobs: services: mysql: - image: mysql/mysql-server:5.6 + image: mysql/mysql-server:5.7 env: MYSQL_ROOT_PASSWORD: leonardo-test MYSQL_USER: leonardo-test diff --git a/docker/run-mysql.sh b/docker/run-mysql.sh index 29d81d39f83..aeec2c72ced 100755 --- a/docker/run-mysql.sh +++ b/docker/run-mysql.sh @@ -1,7 +1,7 @@ #!/usr/bin/env bash -# The CloudSQL console simply states "MySQL 5.6" so we may not match the minor version number -MYSQL_VERSION=5.6 +# The CloudSQL console simply states "MySQL 5.7" so we may not match the minor version number +MYSQL_VERSION=5.7 start() { echo "attempting to remove old $CONTAINER container..." diff --git a/http/src/main/resources/org/broadinstitute/dsde/workbench/leonardo/liquibase/changesets/20170901_cluster-createdDate-default.xml b/http/src/main/resources/org/broadinstitute/dsde/workbench/leonardo/liquibase/changesets/20170901_cluster-createdDate-default.xml index b100269e07b..c46895b651a 100644 --- a/http/src/main/resources/org/broadinstitute/dsde/workbench/leonardo/liquibase/changesets/20170901_cluster-createdDate-default.xml +++ b/http/src/main/resources/org/broadinstitute/dsde/workbench/leonardo/liquibase/changesets/20170901_cluster-createdDate-default.xml @@ -2,6 +2,6 @@ ALTER TABLE CLUSTER - CHANGE createdDate createdDate TIMESTAMP(6) NOT NULL DEFAULT 0 + CHANGE createdDate createdDate TIMESTAMP(6) NOT NULL DEFAULT CURRENT_TIMESTAMP(6) \ No newline at end of file diff --git a/http/src/main/resources/org/broadinstitute/dsde/workbench/leonardo/liquibase/changesets/20171011_cluster_destroyedDate_not_null.xml b/http/src/main/resources/org/broadinstitute/dsde/workbench/leonardo/liquibase/changesets/20171011_cluster_destroyedDate_not_null.xml index 928b9bd3850..8bfd5283be7 100644 --- a/http/src/main/resources/org/broadinstitute/dsde/workbench/leonardo/liquibase/changesets/20171011_cluster_destroyedDate_not_null.xml +++ b/http/src/main/resources/org/broadinstitute/dsde/workbench/leonardo/liquibase/changesets/20171011_cluster_destroyedDate_not_null.xml @@ -3,11 +3,11 @@ \ No newline at end of file diff --git a/http/src/main/scala/org/broadinstitute/dsde/workbench/leonardo/db/LeoProfile.scala b/http/src/main/scala/org/broadinstitute/dsde/workbench/leonardo/db/LeoProfile.scala index c79ab7c9e38..0a4a8f6479b 100644 --- a/http/src/main/scala/org/broadinstitute/dsde/workbench/leonardo/db/LeoProfile.scala +++ b/http/src/main/scala/org/broadinstitute/dsde/workbench/leonardo/db/LeoProfile.scala @@ -120,7 +120,7 @@ private[leonardo] object LeoProfile extends MySQLProfile { implicit val cloudServiceMappedColumnType: BaseColumnType[CloudService] = MappedColumnType .base[CloudService, String](_.asString, s => CloudService.withName(s)) - // mysql 5.6 doesns't support json. Hence writing properties field as string in json format + // TODO: change with mysql upgrade to 5.7 (mysql 5.6 doesn't support json. Hence writing properties field as string in json format) implicit val mapMappedColumnType: BaseColumnType[Map[String, String]] = MappedColumnType .base[Map[String, String], String]( diff --git a/http/src/test/resources/reference.conf b/http/src/test/resources/reference.conf index 2de180f239b..db059b77925 100644 --- a/http/src/test/resources/reference.conf +++ b/http/src/test/resources/reference.conf @@ -5,7 +5,7 @@ # -e MYSQL_USER=leonardo-test \ # -e MYSQL_PASSWORD=leonardo-test \ # -e MYSQL_DATABASE=leotestdb \ -# -d -p 3311:3306 mysql/mysql-server:5.6 +# -d -p 3311:3306 mysql/mysql-server:5.7 application { leoGoogleProject = "leo-project"