-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IA-4681] Update terra-common-lib #4732
Conversation
http/src/main/scala/org/broadinstitute/dsde/workbench/leonardo/db/DbReference.scala
Show resolved
Hide resolved
@@ -365,19 +365,7 @@ class LeoMetricsMonitor[F[_]](config: LeoMetricsMonitorConfig, | |||
val labelSelector = s"leoAppName=${app.appName.value}" | |||
for { | |||
pods <- F.blocking( | |||
client.listNamespacedPod(namespace.value, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this method was changed so that the arguments are now setter functions
http/src/main/scala/org/broadinstitute/dsde/workbench/leonardo/db/DbReference.scala
Show resolved
Hide resolved
@LizBaldo I changed how the mocking is done in that one spec, so 🤞 it should be passing now |
Thanks a bunch! I'll monitor the rest of the tests and will merge early next week |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4732 +/- ##
========================================
Coverage 74.14% 74.14%
========================================
Files 161 161
Lines 15051 15051
Branches 1208 1208
========================================
Hits 11159 11159
Misses 3892 3892
Continue to review full report in Codecov by Sentry.
|
…o into IA-4681-update-tcl
Note that updating to the new kubernetes java client was causing issues with GKE app creation and so given that the scope of this PR is to upgrade to a safe version of okio ( >= 3.4.0), pinning TCL to 1.1.4 lets us do that (okio is 3.6.0 now), while still using the legacy kubernetes java API. We should upgrade to the latest kubernetes API eventually but this is outside of the scope of this PR |
Jira ticket: https://broadworkbench.atlassian.net/browse/IA-4681
Summary of changes
What
Why
Testing these changes
What to test
Who tested and where
jenkins retest
orjenkins multi-test
.