From 5266a6c68476af295d9ea764e1a18a891a857bca Mon Sep 17 00:00:00 2001 From: Daniel_Doehring Date: Sun, 1 Dec 2024 16:04:31 +0100 Subject: [PATCH] Make `PairedExplicitRK2` constructors consistent --- NEWS.md | 8 ++++++++ .../paired_explicit_runge_kutta/methods_PERK2.jl | 4 ++-- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/NEWS.md b/NEWS.md index 2f71c45e57e..6c7c4fe8362 100644 --- a/NEWS.md +++ b/NEWS.md @@ -4,6 +4,14 @@ Trixi.jl follows the interpretation of [semantic versioning (semver)](https://ju used in the Julia ecosystem. Notable changes will be documented in this file for human readability. +## Changes when updating to v0.10 from v0.9.x + +#### Changed + +- The `PairedExplicitRK2` constructor with second argument `base_path_monomial_coeffs::AbstractString` requires + now `dt_opt`, `b1`, `cS` to be given as keyword arguments ([#2184]). + Previously, those where standard function parameters, in the same order as listed above. + ## Changes in the v0.9 lifecycle #### Added diff --git a/src/time_integration/paired_explicit_runge_kutta/methods_PERK2.jl b/src/time_integration/paired_explicit_runge_kutta/methods_PERK2.jl index 2451680a505..d75ee041e3d 100644 --- a/src/time_integration/paired_explicit_runge_kutta/methods_PERK2.jl +++ b/src/time_integration/paired_explicit_runge_kutta/methods_PERK2.jl @@ -98,7 +98,7 @@ function compute_PairedExplicitRK2_butcher_tableau(num_stages, end @doc raw""" - PairedExplicitRK2(num_stages, base_path_monomial_coeffs::AbstractString, dt_opt = nothing, + PairedExplicitRK2(num_stages, base_path_monomial_coeffs::AbstractString; dt_opt = nothing, bS = 1.0, cS = 0.5) PairedExplicitRK2(num_stages, tspan, semi::AbstractSemidiscretization; verbose = false, bS = 1.0, cS = 0.5) @@ -143,7 +143,7 @@ mutable struct PairedExplicitRK2 <: AbstractPairedExplicitRKSingle end # struct PairedExplicitRK2 # Constructor that reads the coefficients from a file -function PairedExplicitRK2(num_stages, base_path_monomial_coeffs::AbstractString, +function PairedExplicitRK2(num_stages, base_path_monomial_coeffs::AbstractString; dt_opt = nothing, bS = 1.0, cS = 0.5) # If the user has the monomial coefficients, they also must have the optimal time step