diff --git a/.readthedocs.yaml b/.readthedocs.yaml index 2a0660cf..191de8ce 100644 --- a/.readthedocs.yaml +++ b/.readthedocs.yaml @@ -16,7 +16,6 @@ conda: submodules: include: - doc/notebooks - - pybind11 recursive: true diff --git a/README.md b/README.md index f8965001..d5665322 100644 --- a/README.md +++ b/README.md @@ -9,12 +9,12 @@ This commit to the **new default branch `main` is the official start of the 1.0 ### Short term -- [ ] fix CI w/ github actions +- [X] fix CI w/ github actions - [ ] Readthedocs with mkdoc -- [ ] Tests -- [ ] Notebook tests -- [ ] Merge PRs #263 #274 -- [ ] Tests +- [x] Tests +- [x] Notebook tests +- [x] Merge PRs #263 #274 +- [x] Tests - [ ] Check Polarization notebooks diff --git a/doc/notebooks b/doc/notebooks index 03d48f9f..dd5eeb54 160000 --- a/doc/notebooks +++ b/doc/notebooks @@ -1 +1 @@ -Subproject commit 03d48f9f143edb54dcb9c3f8331a247a0f59189d +Subproject commit dd5eeb54244bbe2b7e4120083f068f7e5ccdcabb diff --git a/pyproject.toml b/pyproject.toml index 9737e6c0..bceb176e 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -37,6 +37,8 @@ test = [ "nox", "pytest", "pytest-cov", + "scikit-build-core", + "nbval" "scikit-build-core" ] dev = [ @@ -44,6 +46,7 @@ dev = [ "pytest-cov", "scikit-build-core", "pre-commit", + "nbval" ] docs = [ "Sphinx", diff --git a/src/tyssue/core/objects.py b/src/tyssue/core/objects.py index 7bce26f1..ac07db0a 100644 --- a/src/tyssue/core/objects.py +++ b/src/tyssue/core/objects.py @@ -671,7 +671,7 @@ def validate(self): e.g. has only closed polygons and polyhedra """ - return np.alltrue(self.get_valid()) + return np.all(self.get_valid()) def get_valid(self): """Set the 'is_valid' column to true if the faces are all closed polygons,