Feat : Implement progress page component #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamTheKorean
commented
Oct 23, 2024
| import { render, screen } from "@testing-library/react"; | ||
| import Progress from "./progress"; // Adjust the import path as needed | ||
|
|
||
| describe("<Progress/>", () => { |
There was a problem hiding this comment.
#18 (comment). 여기서 언급하신 것처럼 test를 it으로 변경할게요.
sounmind
approved these changes
Oct 24, 2024
Sunjae95
reviewed
Oct 25, 2024
Comment on lines
25
to
27
| expect(screen.getByText(/Easy: 12\/12/i)).toBeInTheDocument(); | ||
| expect(screen.getByText(/Med.: 22\/22/i)).toBeInTheDocument(); | ||
| expect(screen.getByText(/Hard: 1\/1/i)).toBeInTheDocument(); |
There was a problem hiding this comment.
정해진값을 정규식을 사용하여 테스트를 원하신다면 정해진 상수로 테스트하는 방법은 어떨까요?
Comment on lines
25
to
27
| expect(screen.getByText(/Easy: 12\/12/i)).toBeInTheDocument(); | ||
| expect(screen.getByText(/Med.: 22\/22/i)).toBeInTheDocument(); | ||
| expect(screen.getByText(/Hard: 1\/1/i)).toBeInTheDocument(); |
There was a problem hiding this comment.
만약 정규식으로 테스트를 하고싶다면 숫자부분 수정과 i태그를 수정요청드립니다
Suggested change
| expect(screen.getByText(/Easy: 12\/12/i)).toBeInTheDocument(); | |
| expect(screen.getByText(/Med.: 22\/22/i)).toBeInTheDocument(); | |
| expect(screen.getByText(/Hard: 1\/1/i)).toBeInTheDocument(); | |
| expect(screen.getByText(/^Easy: \d{1,2}\/\d{1,2}$/)).toBeInTheDocument(); | |
| expect(screen.getByText(/^Med.: \d{1,2}\/\d{1,2}$/)).toBeInTheDocument(); | |
| expect(screen.getByText(/^Hard: \d{1,2}\/\d{1,2}$/)).toBeInTheDocument(); |
- ^ $ 를통해서 정해진 format작성
- 숫자부분은 총 문제가 75문제 이하니 2자리를 못넘기기에 2자리까지 제한
- i태그는 정확한 string비교를 위해 제거 https://ko.javascript.info/regexp-introduction
@SamTheKorean 님은 어떤 방법이 테스트하기에 용이하다고 생각하시나요?
There was a problem hiding this comment.
어떤 테스트를 할 지 고민했었는데 추천하신 것처럼 정규식에 제한을 두는 것 좋은 생각인 것 같습니다! 수정하겠습니다.
SamTheKorean
force-pushed
the
sam/create-progress-page
branch
3 times, most recently
from
737f440 to
c7d4054
Compare
SamTheKorean
force-pushed
the
sam/create-progress-page
branch
from
c7d4054 to
e6590c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.