Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.7.0] - Functions, arrow funcions and beautifying #109

Open
RedSparrowEU opened this issue Aug 31, 2019 · 1 comment
Open

[2.7.0] - Functions, arrow funcions and beautifying #109

RedSparrowEU opened this issue Aug 31, 2019 · 1 comment

Comments

@RedSparrowEU
Copy link

RedSparrowEU commented Aug 31, 2019

Hello Dimitar,

Thank You very much for the set/get addition! It works great.
I have new gr8 chellenges for You! (and yes, yes, I know You're busy)

Please consider following questions:

1. Function or arrow function as variable should be (maybe optionally) interpreted as normal function:

const myPowFunc = (arg) => { return arg*arg }

const mySqrFunc = function (arg) { return Math.sqrt(arg) }

Currently these functions are to be found in the list of variables.

2. Colors in the Tree (readability)

  • The color scheme could be borrowed from the editor scheme selected by the user. For each specified item - classes, functions, getters/setters and variables. The type (in TS) could be colorized as well.
  • Space before brackets - now, for example, it is difficult to find the right name because it connects to brackets and looks like 0. Arguments should be colorized as well. Brackets gray, commas gray (in other words - as in set color scheme).

3. Types

As Javascript doesn't use types as TypeScript, trees for .js files should be without ": any".
It will improve readability.

4. Quick Filter

Under the heading "FILE SYMBOL EXPLORER: SYMBOLS", could be placed a quick filter input field, working dynamically while typing. The list of elements can then be shortened by using this filter.

Thats's it for the moment. :)
Fingers crossed!

Thanks,
Greg

@RedSparrowEU RedSparrowEU changed the title [2.7.0] - Functions, arrow funcions and beautifying [2.7.0] - Functions, arrow funcions and beautifying :feature Aug 31, 2019
@RedSparrowEU RedSparrowEU changed the title [2.7.0] - Functions, arrow funcions and beautifying :feature [2.7.0] - Functions, arrow funcions and beautifying feature Aug 31, 2019
@RedSparrowEU RedSparrowEU changed the title [2.7.0] - Functions, arrow funcions and beautifying feature [2.7.0] - Functions, arrow funcions and beautifying Aug 31, 2019
@DaGhostman
Copy link
Owner

Hello, Greg!
Thanks for the feedback and I am really glad that you liked the implementation and that you are contributing ideas (oh boy, quite a challenge 😆 )

From what I've understood so far 3. should not be that hard to implement actually, I think I can manage to swap out types So I will try to find some time and address this soon.

About 4. to be completely honest I kinda lost track as to what is supported by the VSC api regarding custom trees, but I would guess that since it was added for the explorer it should be made available soon (if not already) so that would maybe take some time I think.

  1. I haven't thought about that and by your feedback it actually makes sense, so 👍
  2. Now the coloring, well I am not 100% sure that would be doable and would require further/greater investigation and effort. But I would love to hear your thoughts as to how else you consider readability to be improved if the usage of the current code scheme is a no-go?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants