Feedback widget #927
Merged
Feedback widget #927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Storybooks Link For Branch |
|
Coverage Report Link for Branch |
Fbasham
force-pushed
the
feedback-widget
branch
from
a962263 to
ca5e44c
Compare
|
Check out a preview of your pull request here: https://app-servicecanadalabs-dev-pr-preview-3.azurewebsites.net |
will0684
approved these changes
Nov 21, 2023
|
Check out a preview of your pull request here: https://app-servicecanadalabs-dev-pr-preview-3.azurewebsites.net |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch Report a problem widget for feedback widget
The report a problem component has been decommissioned in favour of using the feedback widget (read the design specs in the attached ADO card link above). This widget has a few different states. Initially it should display an interactive component that asks the user if they would like to submit feedback. If yes is clicked, the widget displays a thank you message. If no is clicked, a form is displayed where users must input one of the radio buttons, the extra details textarea is optional. After submitting, the same thank you message is displayed as in if the user clicked the yes button.
There is client-side validation that checks if the radio group has an input that's been clicked. There is also server-side validation that checks this as well. If no input has been checked, the server returns a 400 bad request, but still displays the thank you message. If the submission is successful, the widget returns a 200 status and shows the thank you. If there is a failure because an error is caught, the server returns a 500 status and also displays the thank you message. These are tested in a unit test.
Note:
the following env var have been added/updated (check the ADO pipeline to get their values):