-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unit Tests for /columns API Endpoint #1060
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apply Sweep Rules to your PR?
|
…DLP/Deep-Learning-Playground into unit-test-dataset-endpoint
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
farisdurrani
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit tests for
/columns
Dataset API EndpointGithub Issue Number Here: #1059
What user problem are we solving?
Currently, we have unit tests in
pytest
for the core training files. However, to increase test coverage on our backend, we should add unit tests for the Django training endpoints we have in the codebase.What solution does this PR provide?
Unit tests for the
/columns
API Route under/api/datasets/default/columns
endpoint.Testing Methodology
Checkout this branch on your local machine and then run
cd training && pytest tests/
at the root of the projectAny other considerations
For any utility files that are created for the purpose of being reused across unit tests within
training/
please add it undertest_utils.py
(see example functions I've added)