Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit Tests for /columns API Endpoint #1060

Merged
merged 6 commits into from
Nov 28, 2023
Merged

Conversation

karkir0003
Copy link
Member

Unit tests for /columns Dataset API Endpoint

Github Issue Number Here: #1059
What user problem are we solving?
Currently, we have unit tests in pytest for the core training files. However, to increase test coverage on our backend, we should add unit tests for the Django training endpoints we have in the codebase.

What solution does this PR provide?
Unit tests for the /columns API Route under /api/datasets/default/columns endpoint.

Testing Methodology
Checkout this branch on your local machine and then run cd training && pytest tests/ at the root of the project

Any other considerations
For any utility files that are created for the purpose of being reused across unit tests within training/ please add it under test_utils.py (see example functions I've added)

@karkir0003 karkir0003 requested a review from a team as a code owner November 24, 2023 02:46
Copy link
Contributor

sweep-ai bot commented Nov 24, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

Copy link

sonarcloud bot commented Nov 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@karkir0003 karkir0003 added this pull request to the merge queue Nov 28, 2023
Merged via the queue into nextjs with commit 09ba30d Nov 28, 2023
11 checks passed
@karkir0003 karkir0003 deleted the unit-test-dataset-endpoint branch November 28, 2023 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants