Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]: Proposed Frontend Build Check Workflow #1086

Open
prishavall opened this issue Jan 4, 2024 · 2 comments
Open

[FEATURE]: Proposed Frontend Build Check Workflow #1086

prishavall opened this issue Jan 4, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@prishavall
Copy link
Contributor

prishavall commented Jan 4, 2024

Feature Name

unified Frontend build check workflow to ensure code quality and consistency

Your Name

Prisha Vallamsetti

Description

  1. Linting:
    Checkout codebase
    "npm install -g pnpm"
    Install dependencies using pnpm install
    Run Prettier to ensure code formatting consistency (yarn run format:check)
    Run ESLint (yarn run lint) ensuring its execution separate of Prettier's success
  2. Building & Staging:
    Checkout codebase
    Install dependencies using pnpm install
    Build the frontend assets using yarn build
    Stage the built assets using a custom action rossjrw/pr-preview-action@v1 to create a preview environment
  3. Testing:
    Checkout codebase
    Install dependencies using pnpm install
    Run tests with coverage using yarn run test --coverage
    The workflow configuration is triggered on each pull request so each step is reached and checked
@prishavall prishavall added the enhancement New feature or request label Jan 4, 2024
Copy link
Contributor

github-actions bot commented Jan 4, 2024

Hello @prishavall! Thank you for submitting the Feature Request Form. We appreciate your contribution. 👋

We will look into it and provide a response as soon as possible.

To work on this feature request, you can follow these branch setup instructions:

  1. Checkout the main branch:
```
 git checkout nextjs
```
  1. Pull the latest changes from the remote main branch:
```
 git pull origin nextjs
```
  1. Create a new branch specific to this feature request using the issue number:
```
 git checkout -b feature-1086
```

Feel free to make the necessary changes in this branch and submit a pull request when you're ready.

Best regards,
Deep Learning Playground (DLP) Team

@karkir0003
Copy link
Member

use pnpm as the dependency manager, not yarn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Backlog
Development

No branches or pull requests

2 participants