Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Initial Website #2

Merged
merged 1 commit into from
Jul 28, 2021
Merged

Added Initial Website #2

merged 1 commit into from
Jul 28, 2021

Conversation

KrishSavani
Copy link
Contributor

Done:

  • Add a landing page
  • Add information about the club and its perspective
  • Updates from the club
  • Socials etc

Remaining:

  • Updating Updates Section
  • Responsiveness
  • Dark Mode

@nimit2801 nimit2801 self-requested a review July 28, 2021 10:53
@nimit2801 nimit2801 self-assigned this Jul 28, 2021
nimit2801
nimit2801 reviewed Jul 28, 2021
View reviewed changes
Copy link
Member

@nimit2801 nimit2801 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, can you add the screenshot of the output attaching with this PR?

@KrishSavani
Copy link
Contributor Author

Sure, Here is just the landing page.
output

@nimit2801
Copy link
Member

nimit2801 commented Jul 28, 2021 •
edited
Loading

Sure, Here is just the landing page.
output

Hey, this looks amazing! I'll review the files add merge the PR

nimit2801
nimit2801 approved these changes Jul 28, 2021
View reviewed changes
Copy link
Member

@nimit2801 nimit2801 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍
Thanks for the contribution ✅

@nimit2801 nimit2801 merged commit 5743382 into DSCNUV:main Jul 28, 2021
@nimit2801 nimit2801 linked an issue Jul 28, 2021 that may be closed by this pull request
Create a minimalistic website #1
Open
4 tasks
@KrishSavani
Copy link
Contributor Author

Looking forward to contribute more!
Can u please make two issues as:

  1. Make Responsive
  2. Dark Mode

nimit2801 added a commit that referenced this pull request Jul 28, 2021
@nimit2801
Revert "Add files via upload (#2)"
8af1ffa 
This reverts commit 5743382.
@nimit2801 nimit2801 mentioned this pull request Jul 28, 2021
Merged
nimit2801 added a commit that referenced this pull request Jul 28, 2021
@nimit2801
Revert "Add files via upload (#2)" (#3)
ca3aade 
This reverts commit 5743382.
@nimit2801
Copy link
Member

Can you add all the files from DSCNUV_Website to the root folder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nimit2801 nimit2801 nimit2801 approved these changes

Assignees

@nimit2801 nimit2801

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a minimalistic website
2 participants
@KrishSavani @nimit2801