Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPDM 1.3] Request attributes of GET_CERTIFICATE request should not be hard code with zero. #2510

Open
Zhiqiang520 opened this issue Jan 8, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@Zhiqiang520
Copy link
Contributor

Request attributes of GET_CERTIFICATE request should not be hard code with zero.
I think maybe we should add one new parameter Request attributes into libspdm_try_get_certificate() function just like the parameter slot_id.

Refer to the paragraph 382 Table 38 — GET_CERTIFICATE request message format In DSP0274_1.3.0.pdf.
image

spdm_request->header.request_response_code = SPDM_GET_CERTIFICATE;
spdm_request->header.param1 = slot_id;
spdm_request->header.param2 = 0;

static libspdm_return_t libspdm_try_get_certificate(libspdm_context_t *spdm_context,
const uint32_t *session_id,
uint8_t slot_id,
uint16_t length,
size_t *cert_chain_size,
void *cert_chain,
const void **trust_anchor,
size_t *trust_anchor_size)

@Zhiqiang520
Copy link
Contributor Author

This seems a new feature request.

@steven-bellock steven-bellock added the enhancement New feature or request label Jan 8, 2024
@jyao1 jyao1 self-assigned this Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants