Skip to content

Commit

Permalink
events: properly publish abort events
Browse files Browse the repository at this point in the history
I think this should avoid cases of the "Abort" button sticking around.
  • Loading branch information
Xyene committed Dec 25, 2023
1 parent c126f07 commit 356b146
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 3 deletions.
4 changes: 2 additions & 2 deletions judge/bridge/judge_handler.py
Original file line number Diff line number Diff line change
Expand Up @@ -476,8 +476,8 @@ def on_submission_terminated(self, packet):
self._free_self(packet)

if Submission.objects.filter(id=packet['submission-id']).update(status='AB', result='AB', points=0):
event.post('sub_%s' % Submission.get_id_secret(packet['submission-id']), {'type': 'aborted-submission'})
self._post_update_submission(packet['submission-id'], 'terminated', done=True)
event.post('sub_%s' % Submission.get_id_secret(packet['submission-id']), {'type': 'aborted'})
self._post_update_submission(packet['submission-id'], 'aborted', done=True)
json_log.info(self._make_json_log(packet, action='aborted', finish=True, result='AB'))
else:
logger.warning('Unknown submission: %s', packet['submission-id'])
Expand Down
2 changes: 1 addition & 1 deletion judge/judgeapi.py
Original file line number Diff line number Diff line change
Expand Up @@ -119,5 +119,5 @@ def abort_submission(submission):
# and returns a bad-request, the submission is not falsely shown as "Aborted" when it will still be judged.
if not response.get('judge-aborted', True):
Submission.objects.filter(id=submission.id).update(status='AB', result='AB', points=0)
event.post('sub_%s' % Submission.get_id_secret(submission.id), {'type': 'aborted-submission'})
event.post('sub_%s' % Submission.get_id_secret(submission.id), {'type': 'aborted'})
_post_update_submission(submission, done=True)
1 change: 1 addition & 0 deletions templates/submission/status.html
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
"{{ EVENT_DAEMON_LOCATION }}", "{{ EVENT_DAEMON_POLL_LOCATION }}",
['sub_{{ submission.id_secret }}'], {{ last_msg }}, function (message) {
switch (message.type) {
case 'aborted':
case 'internal-error':
case 'grading-end':
case 'compile-error':
Expand Down

0 comments on commit 356b146

Please sign in to comment.