New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify therubyracer dependency #4

Open

DLvalentine opened this issue Apr 17, 2018 · 1 comment

Assignees

Owner

DLvalentine commented Apr 17, 2018

It isn't just a dev dependency, it is also a runtime dependency

DLvalentine self-assigned this

jamesbebbington commented Jun 29, 2020

Hey @DLvalentine does it need to be? Development on the therubyracer has stalled, and Rails 6 now specifies mini_racer instead.

Seeing as execjs "automatically picks the best runtime available", I think removing the dependency on therubyracer and letting execjs handle it, both simplifies matters and makes it more flexible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment