Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertex renumbering for negative volumes not fully taken into account #1241

Open
lukasdreyer opened this issue Aug 28, 2024 · 0 comments
Open
Labels
Bug For a bug in the Code priority: high Should be solved as soon as possible workload: medium Would take a week or less

Comments

@lukasdreyer
Copy link
Collaborator

Bug report

Describe the bug
Vertex renumbering due to negative volumes is not taken into account for face-neighbor computation.
Only the tree_vertices array is switched, not the node_indices which is passed vertex_indices to t8_cmesh_msh_file_find_neighbors and used to compute face indices of neighboring elements for t8_cmesh_set_join.

Additionally, only switching vertices 0 and 4 for pyramids does not seem correct.

Also see:

#1220 and #865

Estimated priority
Which of these is most applicable (remove the others):

"Priority: high" Should be solved as soon as possible

@Davknapp Davknapp added Bug For a bug in the Code priority: high Should be solved as soon as possible workload: medium Would take a week or less labels Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For a bug in the Code priority: high Should be solved as soon as possible workload: medium Would take a week or less
Projects
None yet
Development

No branches or pull requests

2 participants