Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several professions without match #94

Open
jakke-korpelainen opened this issue Jan 23, 2023 · 6 comments
Open

Several professions without match #94

jakke-korpelainen opened this issue Jan 23, 2023 · 6 comments
Assignees

Comments

@jakke-korpelainen
Copy link

jakke-korpelainen commented Jan 23, 2023

DFHack version 50.05-alpha2 (release) on x86_64

Unable to match profession 'SLAVE' to anything in-game
Unable to match profession 'PRISONER' to anything in-game
Unable to match profession 'BARON_CONSORT' to anything in-game
Unable to match profession 'COUNT_CONSORT' to anything in-game
Unable to match profession 'DUKE_CONSORT' to anything in-game
Unable to match profession 'SHOPKEEPER' to anything in-game
Unable to match profession 'GUILDREP' to anything in-game
Unable to match profession 'MERCHANTBARON' to anything in-game
Unable to match profession 'MERCHANTPRINCE' to anything in-game
Unable to match profession 'TAXCOLLECTOR' to anything in-game
Unable to match profession 'ADVISOR' to anything in-game
Unable to match profession 'ALCHEMIST' to anything in-game
Unable to match profession 'DUNGEONMASTER' to anything in-game
Unable to match profession 'EXECUTIONER' to anything in-game
Unable to match profession 'OUTPOSTLIAISON' to anything in-game
Unable to match profession 'ARCHITECT' to anything in-game

Was trying to see what crashed my stonesense, not sure if this should cause any issues though.

@lethosor
Copy link
Member

Are you using any mods?

@jakke-korpelainen
Copy link
Author

jakke-korpelainen commented Jan 25, 2023

Shouldn't be anything else running at the moment in this world. The freeze occurs in stonesense when I go to a specific Z level so I think there is something breaking silently there. Just thought that these professions might be something that should be fixed as well since they're warnings or errors.

@dejazzhands
Copy link

can i be assigned to this issue? i'd like to contribute!

@lethosor
Copy link
Member

lethosor commented May 8, 2023

Sure, there ya go. (It's not strictly required that you be assigned first, for the purposes of DFHack projects, but I suppose it's helpful for longer threads in particular.)

@dejazzhands
Copy link

i'm trying to narrow down the files that might cause this problem. i saw characterconfiguration.cpp is one of the many (presumably) that assigns professions. are there any other files you can think of?

@jakke-korpelainen
Copy link
Author

i'm trying to narrow down the files that might cause this problem. i saw characterconfiguration.cpp is one of the many (presumably) that assigns professions. are there any other files you can think of?

I suspect the logging come from here:

LogVerbose("Unable to match profession '%s' to anything in-game\n", currentProf);

@myk002 myk002 added this to 50.08-r2 May 10, 2023
@github-project-automation github-project-automation bot moved this to Todo in 50.08-r2 May 10, 2023
@myk002 myk002 moved this from Todo to Being worked on in 50.08-r2 May 10, 2023
@myk002 myk002 removed this from 50.08-r2 May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants