Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Points Required for Skill Advancement #5098

Open
Halifay opened this issue Dec 11, 2024 · 1 comment
Open

Incorrect Points Required for Skill Advancement #5098

Halifay opened this issue Dec 11, 2024 · 1 comment
Labels
good first issue Good for newcomers

Comments

@Halifay
Copy link
Contributor

Halifay commented Dec 11, 2024

Description: The amount of points required to advance to the next level is displayed as 0 for skills at very high levels, which is often observed in combat skills. Considering the known formula for calculating the exact points needed for any level, this appears to be a bug that could be easily addressed.
image

Steps to Reproduce:

Train a skill to a very high level (commonly observed in combat skills).

Observe the points required to advance to the next level.

Expected Behavior: The points required to reach the next level should be displayed accurately according to the known formula.

Actual Behavior: The points required to reach the next level are displayed as 0.

Additional Information:

Version: 51.01 adventure beta

@quietust
Copy link
Member

The issue is that the XP threshold is being fetched from the skill_rating enum type defined in library/xml/df.units.xml rather than being calculated dynamically, so it only has meaningful values for levels up to Legendary+4 (19).

@myk002 myk002 added this to 50.15-r2 Dec 18, 2024
@github-project-automation github-project-automation bot moved this to Todo in 50.15-r2 Dec 18, 2024
@myk002 myk002 added the good first issue Good for newcomers label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Status: Todo
Development

No branches or pull requests

3 participants