Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal Deposit does not accept decimal values #13

Open
0xpatrickdev opened this issue Dec 11, 2023 · 1 comment
Open

Proposal Deposit does not accept decimal values #13

0xpatrickdev opened this issue Dec 11, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@0xpatrickdev
Copy link
Collaborator

If the minimum deposit is something like 0.00001, the UI will not allow the user to submit a deposit the form (only 0 and 1 are accepted). This is because step is hardcoded to 1, as it was assumed minimum deposits would also be at least 1.

Step should be calculated based on minDeposit:

<input
type="number"
min="0"
step="1" // ensures integer
name="deposit"
id="deposit"
ref={depositRef}
defaultValue={minDeposit ? coinsUnit(minDeposit) : ""}

@0xpatrickdev
Copy link
Collaborator Author

Similarly, toast banners do not show decimals. I think coinsUnit is also used here, so should fixing the above should solve this as well.

@0xpatrickdev 0xpatrickdev added the bug Something isn't working label Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant