Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document what names are not possible as machine names. #171

Open
tomprince opened this issue Sep 23, 2021 · 0 comments
Open

Document what names are not possible as machine names. #171

tomprince opened this issue Sep 23, 2021 · 0 comments
Labels
help wanted PR very welcome! triaged Discussed in-team, actionable

Comments

@tomprince
Copy link
Contributor

Given that network is used for specifying the description of deployment, as well as the pkgs to use, that somewhat obviously can't be used.

However, it additionally (appears)[https://github.com/DBCDK/morph/blob/ad13802e59c90d3a6d6c33a0a7cc1ffafbe151af/data/eval-machines.nix#L36) like defaults, resources and require (none of which appear to be used for anything[1]) as well as _file (which is passed to the module system) can't be used as machine names.

Alternatively, the structure could be inverted, so the contents of network is at the top-level, with a nodes key containing all the nodes. Though this would be a backwards incompatible change.

[1] I guess maybe these special attributes were inherited from nixops?

@srhb srhb added the help wanted PR very welcome! label Nov 17, 2021
@srhb srhb added the triaged Discussed in-team, actionable label Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted PR very welcome! triaged Discussed in-team, actionable
Projects
None yet
Development

No branches or pull requests

2 participants