Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement to_json() mutability tests #2

Open
devfoo-one opened this issue Jan 8, 2020 · 0 comments
Open

Implement to_json() mutability tests #2

devfoo-one opened this issue Jan 8, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@devfoo-one
Copy link
Member

devfoo-one commented Jan 8, 2020 •
edited
Loading

Make sure that a call of to_json() does not alter the object.
@devfoo-one devfoo-one added the enhancement New feature or request label Jan 8, 2020
devfoo-one added a commit that referenced this issue Jan 8, 2020
@devfoo-one
- Added deepcopy´s to all from_json() methods to enforce immutability…
e09091d 
… of the input data and implemented first mutability tests (see #2).

- Added Dataset.to_json() test, closes #1
devfoo-one added a commit that referenced this issue Feb 10, 2020
@devfoo-one
- Added deepcopy´s to all from_json() methods to enforce immutability…
5a5fb12 
… of the input data and implemented first mutability tests (see #2).

- Added Dataset.to_json() test, closes #1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@devfoo-one