Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add attribute to VDR/VEX to allow modification of severity #332

Closed
hoggmania opened this issue Nov 6, 2023 · 5 comments
Closed

Add attribute to VDR/VEX to allow modification of severity #332

hoggmania opened this issue Nov 6, 2023 · 5 comments
Labels

Comments

@hoggmania
Copy link

The classification of a vulnerability in NVD can be somewhat divisive & debatable.

Maintainers may wish to alter the severity or an aspect of the vector. Cunsuming organisations may wish to manage a vulnerability and alter the vector/severity.

Adding attributes to a VEX that allow the vector to be altered or severity changed would allow significant reuse in the SCA field and indeed allow SCA providers to integrate in a standard way ino such systems as OWASP Dependency Track.

OpenVEX is also debating such use cases at openvex/spec#31

@jkowalleck
Copy link
Member

Vulnerability spec: https://cyclonedx.org/docs/1.5/json/#vulnerabilities

Maintainers may wish to alter the severity or an aspect of the vector. Cunsuming organisations may wish to manage a vulnerability and alter the vector/severity.

The $.vulnerabilities[].ratings[].severity is handled by CycloneDX document authors.
Every author is able to put in the value that they like. Consumers are also free to alter the CycloneDX document to their needs (as long as they change the $.serialNumber/$.version).

$.vulnerabilities[].ratings[].severity might be bound to a source. You are not expected to modify the severity of others.
If an organization disagrees with an existing severity, they can add their own severity and add themselves as source.

Considering this, @hoggmania, is your request solved?

  • I am not talking about implementation and processes, but about document standards here.

see also

@jkowalleck jkowalleck changed the title Add attribute to VEX to allow modification of severity Add attribute to VDR/VEX to allow modification of severity Nov 6, 2023
@stevespringett
Copy link
Member

Here's an example of what modified severity looks like.
https://github.com/CycloneDX/bom-examples/blob/master/VEX/vex.json

Docs: https://cyclonedx.org/docs/1.5/json/#vulnerabilities_items_ratings

Its a common use case that CycloneDX has supported for several releases. What we don't want, is multiple ways to accomplish modified severity. @hoggmania please let us know if there's anything in the existing implementation that's missing.

@hoggmania
Copy link
Author

Feeling very sorry for wasting people's time when I missed this.....should have tried a bit more RTFM.

Much appreciated!

@kcq
Copy link

kcq commented Mar 7, 2024

@jkowalleck I sort of get the logic and it sort of works with the CycloneDX VEX :-) And maybe its just me... but I expect the CycloneDX doc with the vuln info to be generated by a vuln scanner tool/vendor where it would be immutable in some cases (e.g., could be stored in a 3rd party container registry) and the severity rating change would be done by a consumer in a separate doc. Sounds like you are saying that the consumer would need to duplicate that CycloneDX doc and add their severity as as record, right?

@stevespringett
Copy link
Member

@kcq You could use the external reference type exploitability-statement to specify an external VEX, and if you wanted to include modified severity in that external file, you could.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants