Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phonenumbers should be optional dependecy #42

Open
ar7n opened this issue Apr 9, 2020 · 4 comments
Open

phonenumbers should be optional dependecy #42

ar7n opened this issue Apr 9, 2020 · 4 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@ar7n
Copy link

ar7n commented Apr 9, 2020

It will allow to choose between phonenumbers and phonenumberslite, how it is done in phonenumber_field.

Optional twilio and nexmo dependencies also make sense.

@CuriousLearner
Copy link
Owner

What are the advantages of supporting phonenumberslite?

phonenumbers is there because we wanted to validate phone_numbers and not to have those validations handled in this library.

@ar7n
Copy link
Author

ar7n commented Apr 9, 2020

size of phonenumberslite package is 5Mb vs 32.8M of phonenumbers. Also phonenumbers has larger memory footprint. Validation works same in both packages.

@CuriousLearner CuriousLearner added enhancement New feature or request help wanted Extra attention is needed labels Oct 8, 2020
@vaughnkoch
Copy link

vaughnkoch commented Aug 30, 2023

Thanks for this useful package! I agree - dependencies like twilio and nexmo should be optional. This is especially important for docker images, e.g. in my image:

148K nexmo
28M twilio
48M phonenumbers

@CuriousLearner
Copy link
Owner

Thanks for the input. I agree.

There are two things here, The first is making the backend dependencies optional depending on which SMS backend developer opts for. I will cover this in #87

The other one is to replace phonenumbers with phonenumberslite which I'll handle in another PR, unless of course anyone wants to put in a PR for this :)

Thanks again! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants