Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify targeting mechanisms for all commands #85

Open
Crystalwarrior opened this issue Mar 14, 2023 · 1 comment
Open

Unify targeting mechanisms for all commands #85

Crystalwarrior opened this issue Mar 14, 2023 · 1 comment

Comments

@Crystalwarrior
Copy link
Owner

Currently, commands keep re-implementing targeting mechanisms over and over, leading to some commands being able to target by char name, others by OOC name, third only by just the ID, etc. and it's all a big mess.

There should be a unified targeting mechanism that's able to do all kinds of targeting the command could ever want - similar to get_targets - and with ability to supply multiple types of targets as well, rather than just 1. Additionally, all the commands should start using shlex.split(arg) so as to allow arguments with spaces in them.

@Salanto
Copy link
Contributor

Salanto commented Mar 14, 2023

Just use the playerID. Is is unique and short to type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants