Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lesson 4 - Chapter 12: Win Count Issue #202

Open
seusher opened this issue Mar 24, 2018 · 0 comments
Open

Lesson 4 - Chapter 12: Win Count Issue #202

seusher opened this issue Mar 24, 2018 · 0 comments

Comments

@seusher
Copy link

seusher commented Mar 24, 2018

In this chapter, when you select any one of your zombies, the count shown under "Your Zombie's Win Count:" is shown as the aggregate win count of all your zombies. If I battle 5 times with one zombie and win each time, and then battle for the first time with my second zombie, my second zombie's win count will show as 6.

Since the win and loss count are specified on the Zombie instance itself, this number should be tracked per-zombie. Obviously, this isn't on the blockchain so you are likely just maintaining a count, but it might mislead people who aren't familiar with solidity.

I would suggest changing the wording, or tracking the number per-zombie to have parity with the contract the lesson implements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant