Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rethink postgres_exporter/common/pg16/queries_pg_stat_statements.yml #368

Open
hunleyd opened this issue Sep 19, 2023 · 0 comments
Open
Labels
UNCONFIRMED Initial state. Need's triaged
Milestone

Comments

@hunleyd
Copy link
Collaborator

hunleyd commented Sep 19, 2023

Describe the enhancement you are proposing:
(from #367 (comment))

This is more a critique of this query, and if this is already basically the same as in other pg versions I'll let it slide, but seems like this isn't necessarily a sensible metric, since it's not the mean of the weighted average of queries; I'd assume you'd really need to scale each mean_exec_time by the number of calls (or use total_exec_time again) and then divide by the sum of the number of calls total) to get the true value here. Something to think about, and maybe what we have here is "good enough" for most use cases (really seems like only very skewed query workloads would be drastically affected here).

@hunleyd hunleyd added the UNCONFIRMED Initial state. Need's triaged label Sep 19, 2023
@hunleyd hunleyd mentioned this issue Sep 19, 2023
31 tasks
@keithf4 keithf4 added this to the Future milestone May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UNCONFIRMED Initial state. Need's triaged
Projects
None yet
Development

No branches or pull requests

2 participants