Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export_dataset timeout behavior isn't clear #29

Open
jamesrkg opened this issue May 26, 2017 · 0 comments
Open

export_dataset timeout behavior isn't clear #29

jamesrkg opened this issue May 26, 2017 · 0 comments

Comments

@jamesrkg
Copy link

jamesrkg commented May 26, 2017

The default progress timeout is 30 seconds, which is often not long enough. It's therefore easy to hit a TaskProgressTimeoutError even though the export is continuing in the background and may well succeed. If/when it does information about the file's location is no longer accessible to the user (without them preparing to catch that information ahead of time). The default timeout should be (much) longer and an easier way to get at the progress and location urls would make it easier to work with.

Part of the confusion here imo is the way shoji.wait_progress works.

def wait_progress(r, session, progress_tracker=None, entity=None):

progress_tracker=None here is not the same as giving a custom tracker created with progress_tracker = DefaultProgressTracking(None).

The former results in the default timeout (30) because of this:

if progress_tracker is None:
    progress_tracker = session.progress_tracking

Whereas the latter means there is no timeout, despite both being the result of using None.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant