Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Players get kicked when typing into chat using the 1.7.10 Pack #137

Open
LeStegii opened this issue Aug 5, 2023 · 4 comments
Open
Labels
bug Something isn't working help wanted We need help to solve this issue mod issue Some mod causing issues. Outside Crucible When a bug or issue is not with crucible itself, but with minecraft, forge or thermos code.

Comments

@LeStegii
Copy link

LeStegii commented Aug 5, 2023

Describe the bug
Players get kicked from the server when typing in chat with The 1.7.10 Pack.

To Reproduce
Steps to reproduce the behavior:

  1. Install the 1.7.10 Pack server (https://www.technicpack.net/modpack/the-1710-pack.453902, ArchaicFix removed).
  2. Join the server.
  3. Type something into the chat.

Expected behavior
The message should be displayed, and the player should not be kicked.

Logs
Clientside logs: https://hastebin.cc/otamaducez.css
Serverside logs: [08:10:20] [Server thread/INFO] [net.minecraft.network.NetHandlerPlayServer]: LeStegii lost connection: Internal Exception: java.lang.ArrayIndexOutOfBoundsException: -1

Screenshots
/

Additional context
Couldn't reproduce the issue with a clean crucible setup with only the HQM mod installed.
Works fine on Forge.

Environment (please complete the following information):

@LeStegii LeStegii added the bug Something isn't working label Aug 5, 2023
@LeStegii
Copy link
Author

LeStegii commented Aug 5, 2023

If needed, this is the line which is throwing an exception on the client inside a buildable fork of HQM:
https://github.com/KettleMC-Network/HQM/blob/master/src/main/java/hardcorequesting/network/PacketHandler.java#L224C74-L224C74

@EverNife
Copy link
Member

EverNife commented Aug 5, 2023

I have used HQM myself on a few modpacks. The mod has many different issues. I droped it and started using the less buggy (but still buggy) BetterQuesting.

The HQM is pretty outdated, like from 2015.

The issue here is a PacketDeserialization. To even understand the actual cause of the problem is something 'hard' here.

My suggestion is do not use HQM.

Lets hope someone else has worked a little with HQM and can add some experience on this issue.

@EverNife EverNife added help wanted We need help to solve this issue mod issue Some mod causing issues. labels Aug 5, 2023
@LeStegii
Copy link
Author

LeStegii commented Aug 7, 2023

Pretty much impossible as this mod crashes the client and serverside removal doesn't fix anything. It's also definitly an issue on Thermos based servers as Forge works fine but Thermos and its forks don't. Catching the chat with velocity/bungeecord and pasting the message in chat works fine.

Edit: A clean thermos/crucible setup with only HQM installed works fine.

@EverNife EverNife added the Outside Crucible When a bug or issue is not with crucible itself, but with minecraft, forge or thermos code. label Aug 7, 2023
@EverNife
Copy link
Member

EverNife commented Aug 7, 2023

Well, its complicated, we might need someone who understands the PacketSerialization of HQM to fix this T.T

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted We need help to solve this issue mod issue Some mod causing issues. Outside Crucible When a bug or issue is not with crucible itself, but with minecraft, forge or thermos code.
Projects
None yet
Development

No branches or pull requests

2 participants