Support transfer reversals #20
Labels
Comments
danschmidt5189
added a commit
that referenced
this issue
Jul 13, 2015
Adds support for reversing existing transfers via a new create_reversal method. This method accepts three arguments:
- (Required) The transfer ID - any stringifiable value
- (Optional) Reversal data - a hashref defaulting to {}
- (Optional) Options - a hashref defaulting to {}. Right now the only valid key is 'headers', which is passed verbatim to the LWP::UserAgent as request headers.
The method signature ($id, $data = {}, $opts = {}) is meant as a template for all methods that act on a single, existing object. Right now, WS::Stripe uses a mix of positional and named parameters that is not consistent and requires looking back at the documentation. We should unify these signatures to promote understanding. For operations involving new objects, I'd propose the very-similar signature ($data, $opts = {}).
danschmidt5189
added a commit
that referenced
this issue
Jul 13, 2015
Adds support for reversing existing transfers via a new create_reversal method. This method accepts three arguments:
- (Required) The transfer ID - any stringifiable value
- (Optional) Reversal data - a hashref defaulting to {}
- (Optional) Options - a hashref defaulting to {}. Right now the only valid key is 'headers', which is passed verbatim to the LWP::UserAgent as request headers.
The method signature ($id, $data = {}, $opts = {}) is meant as a template for all methods that act on a single, existing object. Right now, WS::Stripe uses a mix of positional and named parameters that is not consistent and requires looking back at the documentation. We should unify these signatures to promote understanding. For operations involving new objects, I'd propose the very-similar signature ($data, $opts = {}).
danschmidt5189
added a commit
that referenced
this issue
Jul 13, 2015
Adds support for reversing existing transfers via a new create_reversal method. This method accepts three arguments:
- (Required) The transfer ID - any stringifiable value
- (Optional) Reversal data - a hashref defaulting to {}
- (Optional) Options - a hashref defaulting to {}. Right now the only valid key is 'headers', which is passed verbatim to the LWP::UserAgent as request headers.
The method signature ($id, $data = {}, $opts = {}) is meant as a template for all methods that act on a single, existing object. Right now, WS::Stripe uses a mix of positional and named parameters that is not consistent and requires looking back at the documentation. We should unify these signatures to promote understanding. For operations involving new objects, I'd propose the very-similar signature ($data, $opts = {}).
danschmidt5189
added a commit
that referenced
this issue
Jul 14, 2015
Adds support for reversing existing transfers via a new create_reversal method.
danschmidt5189
added a commit
that referenced
this issue
Jul 14, 2015
Support Transfer Reversals (#20)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
No description provided.
The text was updated successfully, but these errors were encountered: