Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Allow lpConduit to be set on liquidity mint/burn actions #24

Open
cronii opened this issue Jul 8, 2023 · 0 comments · May be fixed by #25
Open

[Enhancement] Allow lpConduit to be set on liquidity mint/burn actions #24

cronii opened this issue Jul 8, 2023 · 0 comments · May be fixed by #25

Comments

@cronii
Copy link

cronii commented Jul 8, 2023

Expected Behavior

An optional value lpConduit can be passed in the CrocLpOpts opts param of LP functions (mintAmbient, mintConc, burnAmbient, etc.). lpConduit is already a defined parameter at the smart contract level, but functionality is not exposed to the SDK.

Actual Behavior

Currently, lpConduit is hardcoded as AddressZero prior to encoding, so an LP conduit contract address can never be utilized.

Steps to Reproduce the Problem

  1. await croc.poolEth(USDC).mintAmbientQuote(50, [0.0001, 0.001], { lpConduit: SOME_LP_CONDUIT_ADDRESS })
  2. Check if USDC/ETH LP tokens are minted and sent to caller address

Specifications

  • Version: v0.2.75
  • Platform:
@cronii cronii linked a pull request Jul 8, 2023 that will close this issue
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

allow optional lpConduit param passthrough on liquidity actions cronii/sdk
1 participant
@cronii