Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tech Debt]: standardize terminology for 'tokenA' / 'sellToken' and 'tokenB' / 'buyToken' #3143

Open
benwolski opened this issue Oct 20, 2023 · 0 comments
Open

[Tech Debt]: standardize terminology for 'tokenA' / 'sellToken' and 'tokenB' / 'buyToken' #3143

benwolski opened this issue Oct 20, 2023 · 0 comments
Labels
technical debt This issue involves deferred engineering work

Comments

@benwolski
Copy link
Collaborator

What is needed?

terminology should be standardized within the Ambient app code (i.e. outside the SDK and protocol code) to refer to the sell token as 'tokenA' and the buy token as 'tokenB'

image
@benwolski benwolski added the technical debt This issue involves deferred engineering work label Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
technical debt This issue involves deferred engineering work
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@benwolski