Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tech Debt]: interface all data arrays #3085

Open
emilydrakesmith opened this issue Oct 6, 2023 · 0 comments
Open

[Tech Debt]: interface all data arrays #3085

emilydrakesmith opened this issue Oct 6, 2023 · 0 comments
Labels
good first issue Good for newcomers low-prio technical debt This issue involves deferred engineering work

Comments

@emilydrakesmith
Copy link
Contributor

What is needed?

A common code pattern in React is to code an array of curly-brace objects within a React functional component and map over that data to create child elements to render in the DOM. This can cause surprise TS linting issues when one data type is mixed (eg, can be either type JSX.element or string). All data arrays in the app, even if they are only used locally, should have a shape explicitly described by an interface. Example below from the TransactionDetailsSimplify.tsx file:
Screenshot 2023-10-06 at 10 29 15 AM

@emilydrakesmith emilydrakesmith added good first issue Good for newcomers technical debt This issue involves deferred engineering work low-prio labels Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers low-prio technical debt This issue involves deferred engineering work
Projects
None yet
Development

No branches or pull requests

1 participant