Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V1 API] Remove useless linting suppressions #762

Open
4 tasks
MattToast opened this issue Oct 24, 2024 · 0 comments
Open
4 tasks

[V1 API] Remove useless linting suppressions #762

MattToast opened this issue Oct 24, 2024 · 0 comments
Labels
area: CI/CD Issues related to continuous integration and deployment short task Issues that can be completed and reviewed quickly type: chore Issue outside of general development

Comments

@MattToast
Copy link
Member

MattToast commented Oct 24, 2024

Description

In SmartSim's V1 refactor, several API problems that previously needed to be suppressed have been remedied in the new API. However, several # pylint disable{-next}: ... comments still remain in the code base. We should consider cleaning these up.

Justification

Removing useless suppression makes comments less noisy and makes linting more effective

Implementation Strategy

Enable this setting in .pylintrc

Acceptance Criteria

  • Enable the useless suppression settings in the .pylintrc
  • Ensure pylint complains about useless suppressions
  • Fix up any lingering suppression
  • Pass the CI
@MattToast MattToast added area: CI/CD Issues related to continuous integration and deployment type: chore Issue outside of general development labels Oct 24, 2024
@mellis13 mellis13 added the short task Issues that can be completed and reviewed quickly label Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: CI/CD Issues related to continuous integration and deployment short task Issues that can be completed and reviewed quickly type: chore Issue outside of general development
Projects
None yet
Development

No branches or pull requests

2 participants