Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine and enforce minimum CMake version #736

Open
3 tasks
ashao opened this issue Oct 8, 2024 · 0 comments
Open
3 tasks

Determine and enforce minimum CMake version #736

ashao opened this issue Oct 8, 2024 · 0 comments
Labels
type: feature Issues that include feature request or feature idea

Comments

@ashao
Copy link
Member

ashao commented Oct 8, 2024

Description

Currently the documentation specifies that we require CMake version > 3.13. This has not been extensively tested and we also do not explicitly check the CMake version during smart build. This can lead to compilation errors that are not easy to parse and resolve.

Justification

For new users (and or users on new platforms), we can throw more useful errors and warnings to ease the installation and build experience.

Implementation Strategy

  • Build different versions of CMake and attempt to build SmartSim with them
  • Add a step during smart build that explicitly checks the CMake version
  • Update documentation for requirements
@ashao ashao added the type: feature Issues that include feature request or feature idea label Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature Issues that include feature request or feature idea
Projects
None yet
Development

No branches or pull requests

1 participant