Unexpected path
attr set for SmartSim entities when passing an Optional
path
param
#556
Labels
area: api
Issues related to API changes
bug: minor
A minor bug
good first issue
Issue that is ideal for first-time contributors
short task
Issues that can be completed and reviewed quickly
Description
Currently the
path
parameter to the__init__
methods ofEnsemble
/Model
/Orchestrator
are type hinted as so (or equivalent):However, if a user were to exercise the
Optional
type ofpath
, an invalid path of the string"None"
is set on the object, effectively leaving the object in an invalid state that cannot be launched.How to reproduce
Consider the following repl
Expected behavior
The path should not be set to the string
"None"
, but should instead be set to the current working directory. Whether that is the current working directory of at "compile time" or at "run time" remains to be decided.Alternatively, we could have the
path
parameter not have a default value.System
Any/All
Acceptance Criteria
Model
/Ensemble
/Orchestrator
should bepath=None
param toModel
/Ensemble
/Orchestrator
results in a "valid" path, or disallowed entirelypath=None
is specified the correct default path is setThe text was updated successfully, but these errors were encountered: