Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spike: Install python module to install folder #343

Open
billschereriii opened this issue May 19, 2023 · 2 comments
Open

Spike: Install python module to install folder #343

billschereriii opened this issue May 19, 2023 · 2 comments
Labels
area: build Issues related to builds, makefiles, installs, etc area: python Issues related to the Python Client bug: minor A minor bug type: spike Issues requiring more investigation to define user experience and implementation strategy

Comments

@billschereriii
Copy link
Contributor

Description

At present, the Python module and library are run directly from the source directory. This means that the smartredis.cpython.*.so library is copied from the build directory directly into the source directory. This is perfectly functional, but it pollutes the source directory with built code. We should install the module into the install folder instead.

How to reproduce

Build SmartRedis

Expected behavior

Once built, there should be no generated files in the SmartRedis src subtree.

Notes

setup.cfg should be updated to point to the installed location

@billschereriii billschereriii added area: build Issues related to builds, makefiles, installs, etc area: python Issues related to the Python Client bug: minor A minor bug labels May 19, 2023
@mellis13
Copy link
Collaborator

Result of backlog discussion. This might be better as a spike to figure out how we can not pollute source directory and still be able to do pip install -e . and edit python files without rebuild.

@mellis13 mellis13 added the type: design Issues related to architecture and code design label May 19, 2023
@mellis13 mellis13 changed the title Install python module to install folder Spike: Install python module to install folder May 19, 2023
@billschereriii billschereriii added type: spike Issues requiring more investigation to define user experience and implementation strategy and removed type: design Issues related to architecture and code design labels May 19, 2023
@billschereriii
Copy link
Contributor Author

Symbolic linking the python files to an install location might allow installation without impacting editing (so long as no new python files are added)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: build Issues related to builds, makefiles, installs, etc area: python Issues related to the Python Client bug: minor A minor bug type: spike Issues requiring more investigation to define user experience and implementation strategy
Projects
None yet
Development

No branches or pull requests

2 participants