Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor pipelining #313

Open
billschereriii opened this issue Mar 13, 2023 · 0 comments
Open

Refactor pipelining #313

billschereriii opened this issue Mar 13, 2023 · 0 comments
Labels
area: C++ Issues related to the C++ client type: refactor Issues focused on refactoring existing code

Comments

@billschereriii
Copy link
Contributor

Description

The client pipelining uses CommandLists and vectors<Command*> in parallel, which is redundant in storage. This should be refactored to eliminate the redundancy

Justification

This will improve maintainability of the codebase

Implementation Strategy

One strategy might be to rework the CommandList class to store command data as a vector<command*> internally that we can access for pipelining calls
@billschereriii billschereriii added type: refactor Issues focused on refactoring existing code area: C++ Issues related to the C++ client labels Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: C++ Issues related to the C++ client type: refactor Issues focused on refactoring existing code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@billschereriii