Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement get_metadata_field_names() and get_tensor_names() in Fortran #290

Open
2 tasks
billschereriii opened this issue Jan 11, 2023 · 0 comments
Open
2 tasks
Labels
area: fortran issues related to the Fortran Client type: feature Issues that include feature request or feature idea

Comments

@billschereriii
Copy link
Contributor

billschereriii commented Jan 11, 2023

Description

DataSet objects store multiple metadata fields that are accessible by a name parameter. It would be convenient to be able to get a list of the names of metadata fields in Fortran, corresponding to the following C++ function:

  • std::vector<std::string> get_metadata_field_names()

Similarly, DataSet objects store multiple tensors that are accessible by a name parameter. It would be convenient to be able to get a list of the names of tensors in Fortran, corresponding to the following C++ function:

  • std::vector<std::string> get_tensor_names()

Justification

This will improve the ability of users and developers to inspect and compare the contents of a DataSet

Implementation Strategy

Particular care will need to be made to be made to the array processing to ensure that no memory is leaked. An example of returning a single string may be found in the get_last_error() method recently implemented; an extension to that functionality should be able to accomodate an array of strings.

Acceptance Criteria

  • Implement get_metadata_field_names() and get_tensor_names() in Fortran
  • Update unit and integral test to validate it
@billschereriii billschereriii added type: feature Issues that include feature request or feature idea area: test Issues related to the test suite area: fortran issues related to the Fortran Client labels Jan 11, 2023
@billschereriii billschereriii changed the title Implement get_metadata_field_names() in Fortran Implement get_metadata_field_names() and get_tensor_names() in Fortran Jan 18, 2023
@mellis13 mellis13 removed the area: test Issues related to the test suite label Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: fortran issues related to the Fortran Client type: feature Issues that include feature request or feature idea
Projects
None yet
Development

No branches or pull requests

2 participants