Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fortran: Make tensor size an optional argument for put_tensor unpack_tensor #227

Open
ashao opened this issue Feb 28, 2022 · 0 comments
Open
Labels
area: fortran issues related to the Fortran Client type: feature Issues that include feature request or feature idea

Comments

@ashao
Copy link
Member

ashao commented Feb 28, 2022

Description

Currently, the size of the tensor must be specified when using the put_tensor and unpack_tensor commands. This was largely done to serve as an extra 'check' to ensure that the C/C++ client would not accidentally violate the expected memory space.

This argument can be made an optional argument, perhaps useful as an extra debugging feature.

Justification

This will great simplify the process for users to put/unpack subsets of a tensor. For most other cases, this will remove one argument from the call line.

Implementation Strategy

  • The 'include' files that are used for templating the Fortran subroutines will need to be updated to reflect it being an optional argument
  • A check will need to be done to see if the tensor size argument has been passed: if so, then those dimensions will be passed through the rest of the C/C++ interface, if not, then the SmartRedis client will determine the dimensions using the SHAPE intrinsic
@ashao ashao added type: feature Issues that include feature request or feature idea area: fortran issues related to the Fortran Client labels Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: fortran issues related to the Fortran Client type: feature Issues that include feature request or feature idea
Projects
None yet
Development

No branches or pull requests

1 participant