Refactor: Move "exe_args"
from "model"
to "run_settings"
object in manifest.json
#4
Labels
area: telemetry
Issues related to dashboard telemetry
short task
Issues that can be completed and reviewed quickly
type: refactor
Issues focused on refactoring existing code
Description
Currently in the agreed upon structure for the
manifest.json
file that is used as a handshake between SS and SSDash, themodel.run_settings.exec_args
list of strings is serialized under themanifest["runs"][index]["model"][index_2]["exe_args"]
instead of under a...[index_2]["run_settings"]["exe_args"]
. We should consider moving this information there.Justification
In memory, SmartSim has
exe_args: list[str]
as an attr onRunSettings
. Ideally themanifest.json
should follow the structure of SS's data structures as that makes serialization easier, and reduces the amount of context switching that needs to be done by developers.Refactor for SS
At time of writing (likely that it has moved in push for MVP):
Refactor for SSDash
At time of writing (VERY likely to change in push for an MVP):
The text was updated successfully, but these errors were encountered: