Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restart song when leaving region #1

Open
Menacho15 opened this issue Sep 26, 2022 · 3 comments
Open

Restart song when leaving region #1

Menacho15 opened this issue Sep 26, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@Menacho15
Copy link

This is a feature request to create a config option to restart the song that is playing on a region when the player leaves.

If I can, I'll try to do it by my own and create a pull request.

@arenmarsden
Copy link
Member

Fantastic idea. We would be happy to recieve a PR implementing this! We will discuss this feature internally, however you are more than welcome to open the PR.

@lukemango comment please.

@arenmarsden arenmarsden added the enhancement New feature or request label Sep 30, 2022
@lukemango
Copy link
Member

lukemango commented Sep 30, 2022

hey, thanks for the suggestion - afaik NoteblockAPI works by having a 'radio' in which songs are playing and you add the player to and from the radio (which is how this plugin works) so if we restarted the song it'd restart for everyone as soon as someone walks in the region.

i'll have a peak later today or tomorrow and see if there's a workaround because this would be useful

@arenmarsden
Copy link
Member

hey, thanks for the suggestion - afaik NoteblockAPI works by having a 'radio' in which songs are playing and you add the player to and from the radio (which is how this plugin works) so if we restarted the song it'd restart for everyone as soon as someone walks in the region.

i'll have a peak later today or tomorrow and see if there's a workaround because this would be useful

If all else fails, we can also consider writing our own NoteBlockAPI for a future version; e.g 2.0. This would allow us complete control over what we have the ability to implement, and actually having something audience-based would be a great idea. This would take a little bit, but it would make the plugin a lot more attractive if we decide to go that route - and we can publish the API to Maven Central - no need to keep it internal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants