-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Global] Does not support landscape orientation #11
Comments
Could I take on that issue? |
Recommendations for better landscape support.
Onboarding screens, steps 1 and 2 Onboarding, learn how In order to maximise screen real-estate for written content, I'm proposing we drop the animations from these slides. Including them would mean either putting it above or below the text. Above would push the content out of view, and below means you might not even know they are there. Thank you screen Sheet button 400pt wide. Home, No exposure detected Home, Sheet shown Home, Sheet callout Use a 24pt "safe space" at the top of the content area to keep header and content visually distinct. Home, Potentially exposed / thank you / upload reminder Keeping the animations these two scenarios comes at a significant cost. The main Call To Action for each stage may well be pushed completely out of view. If we feel strongly the animations are important in this orientation, we should render an alternative (smaller) version of them). Button 400pt wide. And without animation (my preference). Home, High alert Code entry Code entry, Consent |
Excellent work @AdamWhitcroft 👍 |
@AdamWhitcroft Can we possibly keep the animations in the tutorial by going to a columnar layout? |
@kpeatt it might work if we scale down the animations (and maybe re-render them as we have clipping of the echoes on the left and right sides) |
The above looks good to me. |
* Make iOS aware of supported languages * New animations * New animations * Add step 3 * Update AE file * Remove AE logs * Revert development team change * Revert development team change * remove extra files * Fix XCode project file * Fix up extra files and broken XCode project * Revert "Merge branch 'new-anims' of https://github.com/CovidShield/mobile into new-anims" This reverts commit 875923e, reversing changes made to b3712f5. * Fixes security issue in logkitty 0.6.1 by updating @react-native-community/cli * Disable application prefix for debug build * Follow PR fixing package.json Co-authored-by: Janic Duplessis <[email protected]> Co-authored-by: Jordan Good <[email protected]> Co-authored-by: Kyle Peatt <[email protected]> Co-authored-by: Jordan Good <[email protected]> Co-authored-by: Henry Tao <[email protected]>
Issue summary
The app doesn't seem to support landscape orientation on Android devices. On iOS, it's partially supported though some text nodes are not visible.
Supporting landscape orientation is important for people who prefer one orientation to another. Some may not have the physical capability of making an adjustment to their device. Supporting only portrait mode could lead to a frustrating user experience.
Steps to reproduce
apk
on an Android deviceBehavior
Expected
Actual
Recommendation
Allow any orientation. Ensure app content, layout, and controls are accessible when switching device orientation.
Specifications
The text was updated successfully, but these errors were encountered: